[Freeipa-devel] [PATCH] 336 Added policies into user details page.

Petr Vobornik pvoborni at redhat.com
Fri Jan 6 13:50:11 UTC 2012


On 01/06/2012 06:14 AM, Endi Sukma Dewata wrote:
> The user details page has been modified to show the password policy
> and Kerberos ticket policy that apply to the user. The policy are
> displayed as read-only since they may affect other users. Changing
> a policy should be done in the respective policy details page.
>
> Ticket #703
>

NACK

1) you are calling krbtpolicy-show without any user specific information 
so it always get the global policy. It should be call with an user argument.

Minor:
2) Why not call pwpolicy-show --user=user_login instead of getting the 
policy's name from dn?

Combining 1), 2) and user-show will allow to get all necessary 
information for the facet in a single batch at refresh.

Otherwise it seems fine.

-- 
Petr Vobornik




More information about the Freeipa-devel mailing list