[Freeipa-devel] [PATCH] 194 Fix ipa-server-install for dual NICs

[Rob Crittenden]

Martin Kosek wrote:
> On Thu, 2012-01-19 at 17:21 -0500, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> On Fri, 2012-01-13 at 10:48 -0500, Rob Crittenden wrote:
>>>> Martin Kosek wrote:
>>>>> It seems I sent two patches with number 189. Sending a patch with a
>>>>> correct number.
>>>>>
>>>>> Martin
>>>>>
>>>>> On Tue, 2012-01-10 at 12:40 +0100, Martin Kosek wrote:
>>>>>> Depends on my patch 188
>>>>>> ---
>>>>>> A server may have 2 or more NICs and its hostname may thus resolve
>>>>>> to 2 and more forward addresses. IP address checks in install
>>>>>> scripts does not expect this setup and may fail or crash.
>>>>>>
>>>>>> This script adds a support for multiple forward addresses for
>>>>>> a hostname. The install scripts do not crash now. When one IP
>>>>>> address is needed, user is asked to choose from all detected
>>>>>> server IP addresses.
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/2154
>>>>
>>>> You have a patch 190 already as well :-)
>>>
>>> Hm, yes :-)
>>>>
>>>> This appears to depend on another patch that I haven't applied yet. Can
>>>> you see if it has unpushed dependencies? (removing the adtrust part was
>>>> relatively easy and unrelated).
>>>>
>>>> rob
>>>
>>> It depended on patch 188 (it was written in the top of the mail). Since
>>> it was pushed today, this patch should be applicable to master branch. I
>>> checked it and it should be OK.
>>>
>>> Martin
>>>
>>
>> Still not applying
>>
>> $ patch -p1 --dry-run<
>> /tmp/freeipa-mkosek-190-fix-ipa-server-install-for-dual-nics.patch
>> patching file install/tools/ipa-dns-install
>> patching file install/tools/ipa-replica-conncheck
>> patching file install/tools/ipa-replica-install
>> patching file ipapython/dnsclient.py
>> Hunk #3 FAILED at 404.
>> 1 out of 3 hunks FAILED -- saving rejects to file ipapython/dnsclient.py.rej
>> patching file ipaserver/install/bindinstance.py
>> patching file ipaserver/install/installutils.py
>>
>
> Hmm, this is a mystery. It applies fine on both my master and ipa-2-2
> branches:
>
> $ git log --oneline
> 8c230f1 Replace float with Decimal
> ea678b5 UI for SELinux user mapping
> ...
> $ git apply ~/patches/freeipa-mkosek-194-ipa-2-2.patch
> $
>
> I wonder why the patch fails on your ipapython/dnsclient.py as its last
> change is somewhere in 2010.
>
> I attached patches for both master and ipa-2-2 (without the trust bits),
> I hope its OK now. These patch includes a fix for unattended mode which
> was introduced in previous version. I was even able to finally assign a
> unique number to this patch :-)
>
> Martin

ACK, pushed to master and ipa-2-2

rob