[Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

Rob Crittenden rcritten at redhat.com
Wed Jan 25 14:12:38 UTC 2012


John Dennis wrote:
> This patch supersedes the previous patch, it corrects two issue Rob
> raised in a later patch review
>
> The fixed issues are:
>
> * spec file did not install ipa_memcached SysV initscript on SvsV systems.
>
> * Typo in the name of the pid file variable in the ipa_memcached initscript
>

NACK, two small things.

ipa-server-install man page needs to be updated with new option.

ipa_memcached is not chkconfig'd on/off when it is installed/uninstalled.

Also, can you update the commit message, it isn't as descriptive as it 
usually is :-)

rob




More information about the Freeipa-devel mailing list