[Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()
Alexander Bokovoy
abokovoy at redhat.com
Fri Jul 6 09:51:28 UTC 2012
Hi,
Obvious clean up in ldapsam_search_users(): every branch is setting the
same base dn and nothing else.
--
/ Alexander Bokovoy
-------------- next part --------------
>From 73250245710e26fecf8034667cb5c2358a592fad Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <abokovoy at redhat.com>
Date: Fri, 6 Jul 2012 12:48:27 +0300
Subject: [PATCH 6/6] reduce redundant checks in ldapsam_search_users() to a
single statement
---
daemons/ipa-sam/ipa_sam.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/daemons/ipa-sam/ipa_sam.c b/daemons/ipa-sam/ipa_sam.c
index 29fc95e457179716c1c70c6f061b1cde9e3f472b..c972930b1056e626159f7c6f044076fc88d827ef 100644
--- a/daemons/ipa-sam/ipa_sam.c
+++ b/daemons/ipa-sam/ipa_sam.c
@@ -1044,13 +1044,7 @@ static bool ldapsam_search_users(struct pdb_methods *methods,
state->connection = ldap_state->smbldap_state;
- if ((acct_flags != 0) && ((acct_flags & ACB_NORMAL) != 0))
- state->base = ldap_state->ipasam_privates->base_dn;
- else if ((acct_flags != 0) &&
- ((acct_flags & (ACB_WSTRUST|ACB_SVRTRUST|ACB_DOMTRUST)) != 0))
- state->base = ldap_state->ipasam_privates->base_dn;
- else
- state->base = ldap_state->ipasam_privates->base_dn;
+ state->base = ldap_state->ipasam_privates->base_dn;
state->acct_flags = acct_flags;
state->base = talloc_strdup(search, state->base);
--
1.7.10.4
More information about the Freeipa-devel
mailing list