[Freeipa-devel] [PATCH] 170 Differentiation of widget type and text_widget input type

Petr Vobornik pvoborni at redhat.com
Tue Jul 17 14:10:06 UTC 2012


On 07/17/2012 01:09 AM, Endi Sukma Dewata wrote:
> On 7/12/2012 8:10 AM, Petr Vobornik wrote:
>> There was a clash of 'type' attribute in widget's spec. Usually 'type'
>> is used for telling a builder which field and widget to build. Text
>> widget used this attribute also for definion of html input type. It was
>> problematic for some special widgets, which defined own field and used
>> text_widget, like service_type or dnszone_name. In those and possibly
>> other cases it used widget type for specifying input type which lead to
>> execution error in Internet Explorer. Firefox and Chrome took it.
>>
>> This patch is changing text_widget's 'type' to 'input_type' which
>> removes the collision and hence fixes the problem.
>>
>> https://fedorahosted.org/freeipa/ticket/2806
>> and half of: https://fedorahosted.org/freeipa/ticket/2834
>
> ACK.
>
Pushed to master.

-- 
Petr Vobornik





More information about the Freeipa-devel mailing list