[Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

[Petr Vobornik]

On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote:
> On 7/16/2012 6:53 AM, Petr Vobornik wrote:
>> Patch description:
>> Adder dialog and details facet for permission type=subtree have small
>> textarea for defining subtree filter. It was unconfortable to define the
>> filter. This difference was removed.
>>
>> https://fedorahosted.org/freeipa/ticket/2832
>>
>> Note regarding related ticket:
>> Resizable textareas are browser-specific. We can do it in code too but I
>> don't think it is worth the effort.
>>
>> Textarea in IE still seems smaller than in Firefox, but it has the same
>> number of rows and cols. I think it has enough space for defining the
>> filter so it should be fixing the problem.
>
> ACK.
>
> Possible improvement, instead of using a fixed column size the text area
> also could be made to occupy 100% of available width. Ideally it should
> have the same width as the text field or drop down list in this dialog.
>

Updated patch attached.

I added two styles:

.textarea-widget textarea {
     width: 250px;
}

.facet-content .textarea-widget textarea {
     width: 400px;
}

First one makes textarea width the same as text_widget - good for dialogs.

Second one makes textareas wider in facets. IMO it is better - more 
space for the text. Also previous implementation was about 330px in FF 
so it isn't big difference. 400px is about the same width as ssh-key 
widget and in also leaves space for possible action panel.

-- 
Petr Vobornik


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0172-1-Bigger-textarea-for-permission-type-subtree.patch
Type: text/x-patch
Size: 1513 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120717/6bfa5d77/attachment.bin>