[Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

[John Dennis]

Great I agree with everything you said.

I'm happy to have the file list be derived from the directory contents. 
Are you planning on doing that in another patch?

FWIW the LINGUAS file was a holdover from when we first set this up 
based exclusively on GNU gettext suggested examples. As things have 
evolved it no longer makes sense. Also the contributing translators file 
is now out of date and was from an earlier era when translators emailed 
.po files to us, so it was easy to maintain. Now that everything is TX 
based we should probably nuke that file or figure out someway to extract 
the contributors from either TX or the po files. I'm not sure we're even 
giving credit to the translators anymore, but we should.

But... I do have one final issue/question. I missed this in the first 
review. po_files is now dependent on update-pot instead of the pot file. 
We had decided that we were only going to regenerate the pot file on 
demand at specific times. Won't this dependency change cause the pot 
file to be updated frequently? (I realize only in the local tree). Note 
that when we run the validations we generate a temporary pot file from 
the current contents of the tree specifically to avoid overwriting the 
pot file.

I suppose having a conversation about when the pot file gets updated is 
a good one to have, we don't do it often enough IMHO. But I'm not sure 
it's correct to modify a file under SCM control if it wasn't intentional.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/