[Freeipa-devel] [PATCH] 1039 fix selinux usermap config options

Rob Crittenden rcritten at redhat.com
Wed Jul 25 03:03:26 UTC 2012


The configuration options for the default user and map order were a bit 
broken in several ways.

I wasn't handling the case where one of the values was coming from LDAP 
so was a list vs as an option which was a string, so all sorts of bad 
interesting things were happening.

There is also the setattr problem. We would normally handle that in a 
validator so it is not a problem but in this case we may need to compare 
two options passed in and we can't do that in a validator. So 
potentially changes may come in as a option, in entry_attrs or from config.

I added a few tests to help keep this robust.

When testing this remember that the user map order list needs to be 
quoted otherwise the shell is going to interpret the $.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-1039-config.patch
Type: text/x-diff
Size: 6022 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120724/4dc55848/attachment.bin>


More information about the Freeipa-devel mailing list