[Freeipa-devel] [PATCH] 151, 152 Removal of illegal options in association dialog

Petr Vobornik pvoborni at redhat.com
Mon Jun 4 16:05:11 UTC 2012


[PATCH] 152 Removal of illegal options in association dialog:

Association dialogs were using non-existent options for find commands. 
It causes error when #2509 is implemented.

Now when creating a find command a check for options existence is 
performed. Option is not used if not present in metadata. It fixes the 
issue.

To be able to do the this check properly patch 151 is required.

[PATCH] 151 Change json serialization to serialize useful data:

json_metadata command creates and sends metadata needed by Web UI. It 
uses __json__ method for serialization of commands, options, objects... 
. A lot of data sent was useless for Web UI and some usefull information 
were missing. We
  * mostly CLI specific option attribues are not send.
  * attributes evaluated to false or None are not send
  * options which are send are not got from takes_aptions attribute but 
by get_options() method. It finally sends usefull option collection for 
commands part of metadata.

In the end the raw amount of data send is aproximately the same.

This patch is needed for Web UI to determine which option it can use in 
which commands.

https://fedorahosted.org/freeipa/ticket/2760
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0151-Change-json-serialization-to-serialize-useful-data.patch
Type: text/x-patch
Size: 5489 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120604/437b9a71/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0152-Removal-of-illegal-options-in-association-dialog.patch
Type: text/x-patch
Size: 1412 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120604/437b9a71/attachment-0001.bin>


More information about the Freeipa-devel mailing list