[Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

[Alexander Bokovoy]

On Mon, 04 Jun 2012, Martin Kosek wrote:
>2) Unit tests need to be updated, currently there is about a dozen test
>case errors, e.g. extra ipakrbprincipalalias attribute in services or
>new ipakrbprincipal objectclass for hosts
I did run unit tests. All passed except two which are not related to
trusts code and were failing before as well. All other issues found
during previous rounds of the review are fixed and squashed in patches
in my fedorapeople's tree.

======================================================================
FAIL: test_automember[39]: host_add: Create u'web5.ipa.local'
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
     self.test(*self.arg)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 249, in <lambda>
     func = lambda: self.check(nice, **test)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 264, in check
     self.check_output(nice, cmd, args, options, expected, extra_check)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 290, in check_output
     assert_deepequal(expected, got, nice)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/util.py", line 331, in assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/util.py", line 325, in assert_deepequal
     doc, sorted(missing), sorted(extra), expected, got, stack
AssertionError: assert_deepequal: dict keys mismatch.
   test_automember[39]: host_add: Create u'web5.ipa.local'
   missing keys = []
   extra keys = ['memberof_hostgroup', 'memberofindirect_netgroup']
   expected = {'dn': u'fqdn=web5.ipa.local,cn=computers,cn=accounts,dc=ipa,dc=local',
'has_keytab': False, 'description': [u'Test host 3'], 'objectclass':
[u'ipasshhost', u'ipaSshGroupOfPubKeys', u'ieee802device', u'ipaobject',
u'nshost', u'ipahost', u'pkiuser', u'ipaservice', u'krbprincipalaux',
u'krbprincipal', u'top'], 'l': [u'Undisclosed location 1'], 'fqdn':
[u'web5.ipa.local'], 'has_password': False, 'ipauniqueid':
[Fuzzy('^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$',
<type 'unicode'>, None)], 'krbprincipalname':
[u'host/web5.ipa.local at IPA.LOCAL'], 'managedby_host':
[u'web5.ipa.local']}
   got = {'dn': u'fqdn=web5.ipa.local,cn=computers,cn=accounts,dc=ipa,dc=local',
'has_keytab': False, 'description': (u'Test host 3',), 'objectclass':
(u'ipaobject', u'nshost', u'ipahost', u'pkiuser', u'ipaservice',
u'krbprincipalaux', u'krbprincipal', u'ieee802device', u'ipasshhost',
u'top', u'ipaSshGroupOfPubKeys'), 'l': (u'Undisclosed location 1',),
'fqdn': (u'web5.ipa.local',), 'memberof_hostgroup': (u'hostgroup2',),
'has_password': False, 'ipauniqueid':
(u'd08fbcb4-afb9-11e1-b06b-5254007ad848',), 'krbprincipalname':
(u'host/web5.ipa.local at IPA.LOCAL',), 'managedby_host':
(u'web5.ipa.local',), 'memberofindirect_netgroup': (u'hostgroup2',)}
   path = ('result',)

======================================================================
FAIL: test_group[21]: group_find: Search for all groups
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
     self.test(*self.arg)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 249, in <lambda>
     func = lambda: self.check(nice, **test)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 264, in check
     self.check_output(nice, cmd, args, options, expected, extra_check)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/test_xmlrpc/xmlrpc_test.py", line 290, in check_output
     assert_deepequal(expected, got, nice)
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/util.py", line 331, in assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/root/rpmbuild/BUILD/freeipa-2.99.0GIT0b74e24/tests/util.py", line 339, in assert_deepequal
     VALUE % (doc, expected, got, stack)
AssertionError: assert_deepequal: expected != got.
   test_group[21]: group_find: Search for all groups
   expected = 5
   got = 6
   path = ('count',)

----------------------------------------------------------------------
Ran 1407 tests in 358.194s

FAILED (errors=2, failures=2)
======================================================================
FAILED under '/usr/bin/python2.7'

** FAIL **

-- 
/ Alexander Bokovoy