[Freeipa-devel] [PATCH] 0050 Fail on unknown Command options

[Petr Viktorin]

On 06/07/2012 11:37 AM, Petr Vobornik wrote:
> On 05/28/2012 04:16 PM, Martin Kosek wrote:
>> On Mon, 2012-05-28 at 15:46 +0200, Petr Vobornik wrote:
>>> On 05/25/2012 09:20 AM, Petr Vobornik wrote:
>>>> On 05/16/2012 02:11 PM, Martin Kosek wrote:
>>>>> On Wed, 2012-05-16 at 10:37 +0200, Petr Viktorin wrote:
>>>>>> On 05/16/2012 09:58 AM, Martin Kosek wrote:
>>>>>>> On Tue, 2012-05-15 at 13:35 +0200, Petr Viktorin wrote:
>>>>>>>> On 05/15/2012 09:55 AM, Martin Kosek wrote:
>>>>>>>>> On Mon, 2012-05-14 at 14:47 +0200, Petr Viktorin wrote:
>>>>>>>>>> The final part of rejecting unknown Command arguments: enable the
>>>>>>>>>> validation, add tests.
>>>>>>>>>> Also fix up things that were changed since the previous patches.
>>>>>>>>>>
>>>>>>>>>> https://fedorahosted.org/freeipa/ticket/2509
>>>
>>> 8><------------------
>>>
>>>>>>
>>>>>> Attaching a rebased patch.
>>>>>>
>>>>>
>>>>> Yup, this one is fine. Now, I did not find issues in the patch itself,
>>>>> tests are clean.
>>>>>
>>>>> However, thanks to this new check I found issues in Web UI
>>>>> (automember,
>>>>> selfservice, delegation screen) which use illegal options and which
>>>>> should be fixed before we push your patch:
>>>>>
>>>>> https://fedorahosted.org/freeipa/ticket/2760
>>>>>
>>>>> Martin
>>>>>
>>>>
>>>> I found an issue in automountmap_add_indirect. It complains that 'key'
>>>> is unknown option.
>>>
>>> I found another options which were functional and now it complains:
>>> * hbacsvcgroup_find: no_hbacsvc
>>> * hbacsvc_find: not_in_hbacsvcgroup
>>> * same issue in sudo commands and sudo command groups.
>>>
>>> I didn't check all relationships, so it may be broken elsewhere as well.
>>>
>>
>> I don't think this is an error on server side - it never had filter
>> options like these in the modules you referenced (though we may add them
>> as an RFE when needed).
>>
>> When you pass these options in the UI to the server side, its just NOOP
>> - or an error when Petr's patch is applied.
>>
>> Martin
>>
> All issues found in Web UI are fixed.
>

Updated and rebased patch attached.


-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0050-05-Fail-on-unknown-Command-options.patch
Type: text/x-patch
Size: 16214 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120612/54e5ceac/attachment.bin>