[Freeipa-devel] [PATCH] 160,161 Trust Web UI

[Endi Sukma Dewata]

On 6/22/2012 11:48 AM, Alexander Bokovoy wrote:
> 2. First two chunks of install/ui/test/data/ipa_init_commands.json and
> install/ui/test/data/ipa_init_objects.json changes look unrelated to
> this ticket.

These files are snapshots of metadata used for demo/testing. I suppose 
Petr was updating the entire files which automatically includes recent 
changes to the metadata.

> ACK

Ditto. The UI code looks fine so it can be pushed. Btw, nice use of 
layout class.

Some comments:

1. The CLI command to add trust is trust-add-ad. Should the UI button 
also say "Add AD"? If we later support additional trust types would that 
appear as separate buttons/dialogs or same button/dialog with maybe 
drop-down list to select the type?

2. The trust-add-ad has an optional --server parameter. There's no 
corresponding field in the UI. Is this parameter supported?

3. In the search page we might be able add some other columns such as 
NetBIOS name, trust type, or status (when it's available later) which 
can be obtained using the --all option.

4. With Alexander's new patch the ipantsecurityidentifier in the UI 
should be removed/replaced with ipanttrusteddomainsid.

The followings are comments for the server:

5. Should the trust-show return the realm_admin & realm_server? If so 
they should be displayed in the details page too.

6. Would we support changing the trust password later? If so we would 
need an action panel.

7. If you add a trust with incomplete parameters the server will return 
an internal error:

   % ipa trust-add-ad ad.test
   ipa: ERROR: an internal error has occured

8. If you add the same trust again (correctly) the server will accept it 
without error.

-- 
Endi S. Dewata