[Freeipa-devel] [PATCH] 159 Action panel for certificates

[Petr Vobornik]

Updated patch attached.

On 06/25/2012 05:09 PM, Endi Sukma Dewata wrote:
> On 6/12/2012 7:48 AM, Petr Vobornik wrote:
>> This is a continuation of effort which transforms status widgets with
>> buttons executing actions to separate status widget and action panels.
>> This patch strips certificate status widget of its buttons and separates
>> the actions to their own objects. Appropriate modifications are taken in
>> host and service details facets.
>>
>> New certificate loader, facet policy and evaluator are introduced to
>> make actions and status widget independent. On facet load event new
>> certificate facet policy loads a certificate from result. Unfortunately
>> results don't contain revocation reason so it also executes additional
>> cert-show command to get the revocation reason. Policy store the
>> certifacete to facet. It raises the certifacet_loaded event to notify
>> certificate evaluator and status widget. Status widget updates its
>> state. Certificate evaluator updates state and actions get disabled or
>> enabled.
>>
>> https://fedorahosted.org/freeipa/ticket/2250
>
> I'm testing using self-signed CA. When I open the host/service details
> page there's a JS error at certificate.js:928 (undefined
> status_revoked), so the page seems to hang and looks blank. In the old
> code the status_revoked panel will only be created if you use Dogtag CA
> (the IPA.cert.is_selfsign() will return false). This check might not be
> necessary anymore because you can just hide the panel.
>

Fixed - Not the panel is always created but it remains hidden 
(display:none).

I also removed calling cert-show on facet load when using selfsign.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0159-1-Action-panel-for-certificates.patch
Type: text/x-patch
Size: 41700 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120626/6348b853/attachment.bin>