[Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

[Petr Vobornik]

Updated patch attached. See comments below.

On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote:
> On 5/3/2012 8:26 AM, Petr Vobornik wrote:
>> On 05/03/2012 03:19 PM, Petr Vobornik wrote:
>>> I found that limitation of maximum pkey length in facet header is not
>>> working well. Attaching patch #134 which actually calculates it.
>>
>> I found useless line in the patch. Corrected version attached.
>
> Try adding a very long DNS zone, then open the zone. Compare the
> breadcrumbs in the DNS Resource Records page and in the Settings page,
> in my case the second one is a bit longer. I think the length of the
> breadcrumb should be calculated differently.

I remade how breadcrumb is limited. Now it tries to use as much space 
available with keeping low complexity level of calculation. It still 
uses an average but now the average is calculated in two phases in order 
to neglect a presence of short keys.

>
> Btw, I just noticed that the facet tab label for DNS Resource Records is
> changed to 'Search'. Same problem happens in Automount.
>

New ticket: #2744, patch on the list.


-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0134-2-Improved-calculation-of-max-pkey-length-in-facet-hea.patch
Type: text/x-patch
Size: 4988 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120510/085045ef/attachment.bin>