[Freeipa-devel] [PATCH] 0047 Do not use extra command options in ACI, permission, selfservice
Martin Kosek
mkosek at redhat.com
Mon May 14 08:40:17 UTC 2012
On Mon, 2012-05-14 at 10:00 +0200, Martin Kosek wrote:
> On Thu, 2012-05-10 at 13:07 +0200, Petr Viktorin wrote:
> > This is the second and likely the next-to-last part of disabling extra
> > command options (after this it's just test fixes and turning the
> > checking on).
> >
> > Part of the work for https://fedorahosted.org/freeipa/ticket/2509
> >
>
> This patch looks and works OK. I just think you missed a pkey_only
> attribute for aci_find command. pkey_only is being passed to aci_find
> command by selfservice_find and delegation_find commands and it would
> fail in the hardened tests because it is not defined in aci_find command
> as it is not based on LDAPSearch class but crud.Search.
>
> It just needs to be added to aci_find command and it should be fine.
>
> Martin
Petr³ noticed that pkey_only was already explicitly added to
takes_options of aci_find command. The patch is OK then.
ACK. Pushed to master.
Martin
More information about the Freeipa-devel
mailing list