[Freeipa-devel] [PATCH] 1016 check for replication agreements

[Martin Kosek]

On Thu, 2012-05-17 at 10:52 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Wed, 2012-05-16 at 18:25 -0400, Rob Crittenden wrote:
> >> In ipa-replica-install we infer that a replication agreement exists if
> >> the host exists. Add an explicit check instead.
> >>
> >> What I did to test this was to break out of the installation right after
> >> replication succeeded. Then I'd run ipa-server-install --uninstall and
> >> try the replica install again.
> >>
> >> rob
> >
> > I was also able to reproduce the issue by installing master and replica,
> > then deleting the replica host entry and running the ipa-replica-install
> > again.
> >
> > The patch works fine, I would just improve the following notice:
> >
> > $ ipa-replica-install INFO_FILE
> > ...
> > A replication agreement for this host already exists. It needs to be
> > removed.
> >      % ipa-replica-manage del vm-098.idm.lab.bos.redhat.com
> >
> > ... and add "--force" flag to the recommended command. Otherwise, user
> > will receive an error as obviously the replica is not alive anymore.
> > Maybe we could also suggest that this should be run on a master machine
> > so that users don't try to run it on a replica.
> >
> > Martin
> >
> 
> Good idea, updated.
> 
> rob

Thanks ok, thanks. ACK, pushed to master.

Martin