[Freeipa-devel] [PATCH] 0052 Fix the pwpolicy_find post_callback

Rob Crittenden rcritten at redhat.com
Fri May 18 14:03:00 UTC 2012


Petr Viktorin wrote:
> The pwpolicy-find command had a bad condition that made IPA convert
> lifetime values for output only if those values were *not* being retrieved.
> With this patch, the conversion routine is called unconditionally (it
> has its own check for presence of the attributes).
>
> https://fedorahosted.org/freeipa/ticket/2726
>
> Also, have the sorting code use a key function instead of a cmp; this is
> a Python best practice.
> Improve a comment -- policies with higher priority are and always were
> at the *end* of the list, not the beginning. (I'm not sure if we want it
> this way?)
>
> Regression test included.

I haven't checked this in detail yet but the comment about priority may 
be wrong. The priority is such that the lower the number the higher the 
priority. I think that is what it meant.

rob




More information about the Freeipa-devel mailing list