[Freeipa-devel] [PATCH] 0052 Fix the pwpolicy_find post_callback

[Petr Viktorin]

On 05/18/2012 04:24 PM, Martin Kosek wrote:
> On Fri, 2012-05-18 at 10:03 -0400, Rob Crittenden wrote:
>> Petr Viktorin wrote:
>>> The pwpolicy-find command had a bad condition that made IPA convert
>>> lifetime values for output only if those values were *not* being retrieved.
>>> With this patch, the conversion routine is called unconditionally (it
>>> has its own check for presence of the attributes).
>>>
>>> https://fedorahosted.org/freeipa/ticket/2726
>>>
>>> Also, have the sorting code use a key function instead of a cmp; this is
>>> a Python best practice.
>>> Improve a comment -- policies with higher priority are and always were
>>> at the *end* of the list, not the beginning. (I'm not sure if we want it
>>> this way?)
>>>
>>> Regression test included.
>>
>> I haven't checked this in detail yet but the comment about priority may
>> be wrong. The priority is such that the lower the number the higher the
>> priority. I think that is what it meant.
>>
>> rob
>>
>
> Yup, the comment was right. Lower numbers, i.e. password policies with
> higher priority, were sorted in the top.
>
> Martin
>

Ah, I see. Made it clear so the next person is not confused.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0052-02-Fix-the-pwpolicy_find-post_callback.patch
Type: text/x-patch
Size: 4981 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120518/3c5dfd6d/attachment.bin>