[Freeipa-devel] [PATCH] 258 Remove LDAP limits from DNS service

[Petr Viktorin]

On 05/10/2012 09:31 AM, Martin Kosek wrote:
> bind-dyndb-ldap persistent search queries LDAP for all DNS records.
> The LDAP connection must have no size or time limits to work
> properly.
>
> This patch updates limits both for existing service principal
> on updated machine and for new service principals added
> as a part of DNS installation.
>
> https://fedorahosted.org/freeipa/ticket/2531
>

Yes, the limits are set correctly on both install and upgrade.
ACK



Minor style nitpicks:

> +            root_logger.critical("Could not modify principal's %s entry: %s" \
> +                    % (dns_principal, str(e)))

The backshashes are unnecessary inside parentheses.

> +        dnsupdates[dns_service_dn] = {'dn' : dns_service_dn,
> +                                      'updates' : limit_updates}

Don't put a space before a semicolon.


-- 
Petr³