[Freeipa-devel] [PATCH] 1019 require policycoreutils if SELinux is enabled

[Rob Crittenden]

Petr Viktorin wrote:
> On 05/23/2012 08:03 PM, Rob Crittenden wrote:
>> Petr Viktorin wrote:
>>> On 2012-05-18 17:53, Rob Crittenden wrote:
>>>> We don't have an explicit requires on the policycoreutils package in
>>>> the
>>>> client because SELinux is not required (just recommended).
>>>>
>>>> SELinux can be enabled without this package so check for that condition
>>>> and don't allow installation if it is the case. The resulting install
>>>> will be rather broken.
>>>>
>>>> Also check on the server when installing. This should never happen but
>>>> in theory it could do the server install then fail in the client
>>>> because
>>>> of this.
>>>>
>>>> rob
>>>>
>>>
>>> All other platform-dependent services have a default defined in
>>> ipapython/services.py.in. Shouldn't check_selinux_status have one, too?
>>
>> Yes, you're right, I forgot to add that.
>>
>> Patch updated.
>>
>> rob
>
> Unfortunately, the patch doesn't apply.
>
>
> I also found a comment typo in ipapython/platform/redhat.py &
> ipapython/platform/fedora.py:
>
>> +# Everything else is made available through these symbols when they
>> directly
>> +# imported into ipapython.services:
>
> s/they directly/they are directly/
>

Fixed and rebased. This requires patch 1014 to apply.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-1019-3-selinux.patch
Type: text/x-diff
Size: 10182 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120524/f1424d66/attachment.bin>