[Freeipa-devel] [PATCH] Make enabling the autofs service more robust

Jakub Hrozek jhrozek at redhat.com
Wed Nov 7 08:14:14 UTC 2012


On Tue, Nov 06, 2012 at 08:57:06AM +0100, Jan Cholasta wrote:
> On 29.10.2012 17:21, Jakub Hrozek wrote:
> >An improvement based on Honza's suggestion.
> >
> 
> You might want to remove the try block around
> "sssdconfig.activate_service('autofs')". If it throws NoServiceError
> at this point, there is something really broken in SSSDConfig, in
> which case it is better to display a traceback rather than a nice
> error message IMO.
> 

I guess this really depends on what the consistent behaviour of the
installer tools is.

My take would be to print an error message to the terminal and a
traceback to a logfile.

I can change the patch, technically that's not a problem, just let me
know if printing a traceback is the preferred way.




More information about the Freeipa-devel mailing list