[Freeipa-devel] [PATCH] Add Beta versioning

[Martin Kosek]

On 11/10/2012 12:08 AM, Dmitri Pal wrote:
> On 11/09/2012 05:52 PM, Simo Sorce wrote:
>> On Fri, 2012-11-09 at 15:59 -0500, Dmitri Pal wrote:
>>> On 11/09/2012 07:58 AM, Petr Vobornik wrote:
>>>> On 11/09/2012 01:43 PM, Lynn Root wrote:
>>>>> The VERSION file and Makefile now handles 'beta' release parameters
>>>>> when making s/rpms.
>>>>>
>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/2893
>>>>>
>>>>> Lynn Root
>>>>> Associate Software Engineer
>>>>> Red Hat
>>>> Thanks for the patch.
>>>>
>>>> In a next patch, I'd suggest to follow patch-naming conventions
>>>> https://fedorahosted.org/freeipa/wiki/PatchFormat . Also include the
>>>> patch number into a mail subject, it helps to keeping track of patches.
>>>>
>>> OK, finally. It is a good time to ask.
>>>
>>> Several years ago when we adopted this format I was wondering what is
>>> the exact sequence of operations one should do to make the resulting
>>> patch follow the format.
>>> I never figured it out so I never adopted the format for the patches I
>>> provide for ding-libs from time to time.
>>>
>>> So in the title of the commit message I put (for example):
>>> [INI] Remove code that allows dup sections
>>>
>>> the I do git format-patch with arguments
>>> this translates into a patch with name
>>> 0001-INI-Remove-code-that-allows-dup-sections.patch
>>>
>>> So am I supposed to the manually rename the patch to follow the format
>>> or have a script to do that or there is some other way that I do not
>>> know about that would allow me to provide patches following the format
>>> above right out of the git format-patch so that I do not need to do the
>>> renaming?
>> This patch format rule is followed only on freeipa-devel for Freeipa
>> patches.
>>
>> Some people have developed scripts to do the renaming automatically.
>>
>> ding libs stuff is tracked on sssd-devel which does not use this patch
>> format rule, we enver felt it necessary in sssd development.
>>
>> Simo.
>>
> I understand. It was more a conceptual question. It looks like the
> answer "there are scripts to do renaming that each developer has".
> Thanks. This is all I was looking for.
> 

Right. I understand that it may be difficult to follow the patch naming rule
for new people in the project. But I personally like both numbering and naming
conventions as it helps me with locating patches when reviewing and with
referencing patch numbers in IRC conversations.

The script is the most straightforward approach to choose For example when I am
submitting a patch, all I need to do is to run a script which will extract the
patch from git, name and number it correctly and opens me a Compose Email
window in my MUA with patch already attached and description taken from the
patch description. It can even upload the patch to Trac Ticket and switch
"patch sent for review" to 1.

If people are interested in the script, I can upload it to some github repo and
we can link it then from our freeipa.org Contribute page.

Martin