[Freeipa-devel] [PATCH 0022] Relax restriction for leading/trailing whitespaces in *-find commands

Martin Kosek mkosek at redhat.com
Wed Nov 14 11:08:46 UTC 2012


On 10/31/2012 01:16 PM, Tomas Babej wrote:
> On 10/31/2012 12:15 PM, Martin Kosek wrote:
>> On 10/31/2012 10:16 AM, Martin Kosek wrote:
>>> On 10/30/2012 03:08 PM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> All *-find commands now enable leading/trailing whitespaces in the
>>>> search phrase. Behaviour has been implemented directly into
>>>> crud.Search class.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/2981
>>>>
>>>> Tomas
>>>>
>>> ACK, works fine.
>>>
>>> Martin
>>>
>> I take the ACK back, just found out you forgot to re-generate API.txt which
>> makes the build fail:
>>
>>
>> # make rpms
>> ...
>> Argument 'criteria?' in command 'aci_find' in API file not found
>> Argument count in aci_find of 0 doesn't match expected: 1
>> Argument criteria? of command aci_find in ipalib, not in API file:
>> Str('criteria?', noextrawhitespace=False)
>> Argument 'criteria?' in command 'delegation_find' in API file not found
>> Argument count in delegation_find of 0 doesn't match expected: 1
>> Argument criteria? of command delegation_find in ipalib, not in API file:
>> Str('criteria?', noextrawhitespace=False)
>> Argument 'criteria?' in command 'selfservice_find' in API file not found
>> Argument count in selfservice_find of 0 doesn't match expected: 1
>> Argument criteria? of command selfservice_find in ipalib, not in API file:
>> Str('criteria?', noextrawhitespace=False)
>>
>> There are one or more changes to the API.
>> Either undo the API changes or update API.txt and increment the major version
>> in VERSION.
>> make: *** [version-update] Error 1
>>
>> Martin
> Update patch version attached. I regenerated API.txt and incremented
> IPA_API_VERSION_MINOR to 45.
> 
> Tomas

ACK. We will just need to rebase it when the patch is about to be pushed (when
work on 3.2 starts).

Martin




More information about the Freeipa-devel mailing list