[Freeipa-devel] [PATCHES] Re: Changes to use a single database for dogtag and IPA

Petr Viktorin pviktori at redhat.com
Wed Nov 21 13:59:28 UTC 2012


On 11/21/2012 01:29 PM, Petr Viktorin wrote:
> On 11/19/2012 05:35 PM, Martin Kosek wrote:
[...]
>>
>> When reading the patches, I also saw few places with magic constant
>> "7389"
>> (your "Fix schema replication from old masters" patch and Ade's patch). I
>> wonder, would "dogtag.Dogtag9Constants.DS_PORT" be more readable?
>
> Fixed in this patch, I'll look at the other one soon.
>

Here is Ade's patch with the magic constants removed.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-alee-0001-05-Changes-to-use-a-single-database-for-dogtag-and-IPA.patch
Type: text/x-patch
Size: 36145 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20121121/612d640d/attachment.bin>


More information about the Freeipa-devel mailing list