[Freeipa-devel] [PATCH] 314-315 Limit unindexed searches

[Rob Crittenden]

Martin Kosek wrote:
> On 09/26/2012 08:58 PM, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> These 2 patches significantly limit the number of unindexed LDAP searches we do
>>> in IPA. I used our unit test suite as a good source of different LDAP searches
>>> run by our command suite.
>>>
>>> Most of the remaining unindexed searches are produced either by our general
>>> term search ("ipa service-find TERM") which hit every object parameter and DNS
>>> commands (idnsname is not indexed yet). I am thinking about indexing about
>>> idnsName as well...
>>>
>>
>> Patch 314 looks ok. It addresses ticket 3025 as well (ipakrbprincipalalias).
>>
>
> I added this ticket number to the patch too. Btw. managedBy attribute mentioned
> in the ticket was already added to indexed in ticket #2866.
>
>> For 315 I'd prefer we add a new exception type to mirror
>> ldap.NOT_ALLOWED_ON_NONLEAF and catch that in delete instead of DatabaseError.
>
>
> This is a very good catch, it will make this procedure safer when there is an
> actual DatabaseError raised.
>
> Updated patches attached.
>
> Martin
>

ACK, pushed to master and ipa-3-0

rob