[Freeipa-devel] [PATCH 0014] Improve user addition to default group in host-add

Martin Kosek mkosek at redhat.com
Wed Oct 3 07:39:55 UTC 2012


On 10/01/2012 03:38 PM, Tomas Babej wrote:
> On 09/26/2012 04:12 PM, Martin Kosek wrote:
>> On 09/26/2012 03:23 PM, Tomas Babej wrote:
>>> On 09/25/2012 12:37 PM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> On adding new user, host-add tries to make it a member of default
>>>> user group. This, however, can raise AlreadyGroupMember when the
>>>> user is already member of this group due to automember rule or
>>>> default group configured. This patch makes sure AlreadyGroupMember
>>>> exception is caught in such cases.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3097
>>>>
>>>> Tomas
>>> I fixed the typo in the commit message. It refers to the proper command now.
>>>
>>> Tomas
>> I would also like to see the tests that Petr Viktorin already asked for.
>>
>> Setting an automember default group to ipausers, adding a user and checking the
>> result should be enough.
>>
>> Martin
>>
> I added a relevant test to the test_host_plugin.py file.
> 
> Tomas

ACK. Pushed to master, ipa-3-0.

Martin




More information about the Freeipa-devel mailing list