[Freeipa-devel] [PATCHES] 0086-0088 Generate Firefox extension on upgrades

[Petr Vobornik]

On 10/09/2012 05:26 PM, Petr Viktorin wrote:
> On 10/09/2012 05:16 PM, Petr Viktorin wrote:
>> https://fedorahosted.org/freeipa/ticket/3150
>>
>>
>> Patch 0086:
>> I found an old unused function while working on this, the patch
>> removes it.
>>
>> Patch 0087:
>> Replica files generated on older masters don't contain the Firefox
>> extension files. Skip installing them in this case.
>>
>> Patch 0088:
>> Servers upgraded from IPA 2.2 need the Firefox extension installed. This
>> is done in ipa-upgradeconfig if they're missing.
>> I made the setup_firefox_extension method independent on the
>> httpinstance state (which is mostly set in create_instance).
>> Similarly, the files are installed ipa-replica-install if they're
>> missing (i.e. skipped by the previous patch).
>> If the Signing-Cert is not on this master, create an unsigned extension
>> using the "zip" command. I needed to add Popen's `cwd` argument to
>> ipautil.run() to get the right filenames out of zip.
>>
>> The patches add "copy_template_file" and "copy_file_if_exists" utilities
>> I've written for some of my WIP patches, expect me to use them more when
>> I get time to work on the installer code.
>>
>
> In my previous mail I've attached an old version of patch 88. Please use
> this one. Sorry!
>
>

nack

1) patch 83-01 doesn't apply.

2) When pwd is supplied to setup_firefox_extension `db = 
certs.CertDB(realm, subject_base=subject_base)` is skipped and therefore 
`db.has_nickname` will fail.


-- 
Petr Vobornik