[Freeipa-devel] [PATCH] 88 ipa-adtrust-install: restart httpd to pick up new plugins

Martin Kosek mkosek at redhat.com
Wed Oct 24 10:31:57 UTC 2012


On 10/24/2012 12:19 PM, Sumit Bose wrote:
> Hi,
> 
> this patches fixes https://fedorahosted.org/freeipa/ticket/3185 by
> restarting httpd as one of the last steps of ipa-adtrust-install.
> 
> bye,
> Sumit
> 

This patch is targeted to pick up trust plugins (adtrustinstance, dcerpc)
installed during freeipa-server-trust-ad RPM install? I am still not sure if we
should not rather reload httpd server during freeipa-server update %post,
because this way, httpd will be restarted every time that someone runs
ipa-adtrust-install even though the plugins were already picked up long time ago...

If we go your way, I would avoid bare except clause, but rather use something
like this:

try:
    ipaservices.knownservices.httpd.restart()
except ipautil.CalledProcessError, e:
    root_logger.error("Failed to restart httpd: %s", e)

Martin




More information about the Freeipa-devel mailing list