[Freeipa-devel] [PATCH] Switch %r specifiers to %s in Public errors

[Jan Cholasta]

Hi,

On 29.10.2012 19:54, Lynn Root wrote:
> Hi all!
>
> This switch drops the preceding 'u' from strings in public error messages.
>
> Ticket: https://fedorahosted.org/freeipa/ticket/3121
>
> This patch also addresses the unfriendly 'u' from re-raising errors from the external call to netaddr.IPAddress by passing a bytestring to the function.
>
> Ticket: https://fedorahosted.org/freeipa/ticket/2588
>
>
> My first patch (and freeipa dev list email) ever! Let me know where there's room to improve.
>
> Lynn Root
> Associate Software Engineer
> Red Hat
>

I think it would be nice if you kept the quotes around the values, as 
that is probably the reason "%r" was used in the first place - i.e. use 
"'%s'" instead of plain "%s".

Congratulations on your first patch and welcome!

Honza

-- 
Jan Cholasta