[Freeipa-devel] [PATCH] 0055 Fix tests which fail after ipa-adtrust-install

[Tomas Babej]

On 08/08/2013 04:09 PM, Ana Krivokapic wrote:
> Hello,
>
> This patch should fix the failing unit tests.
>
> https://fedorahosted.org/freeipa/ticket/3852
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

There are two tests failing on my machine when running the tests after 
ipa-adtrust-install with your patch applied:

======================================================================
FAIL: test_group[24]: group_find: Search for POSIX groups
----------------------------------------------------------------------
Traceback (most recent call last):
[...]
AssertionError: assert_deepequal: dict keys mismatch.
   test_group[24]: group_find: Search for POSIX groups
   missing keys = []
   extra keys = ['ipantsecurityidentifier']
   expected = {'dn': 
ipapython.dn.DN('cn=editors,cn=groups,cn=accounts,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com'), 
'cn': [u'editors'], 'objectclass': Fuzzy(None, None, <function <lambda> 
at 0x3768c08>), 'gidnumber': [Fuzzy('^\\d+$', <type 'basestring'>, 
None)], 'ipauniqueid': 
[Fuzzy('^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$', 
<type 'unicode'>, None)], 'description': [u'Limited admins who can edit 
other users']}
   got = {'dn': 
u'cn=editors,cn=groups,cn=accounts,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com', 
'cn': (u'editors',), 'objectclass': (u'top', u'groupofnames', 
u'posixgroup', u'ipausergroup', u'ipaobject', u'nestedGroup', 
u'ipantgroupattrs'), 'ipantsecurityidentifier': 
(u'S-1-5-21-1457515837-642396627-3509099663-1002',), 'gidnumber': 
(u'1804600002',), 'ipauniqueid': 
(u'7c6e1672-0039-11e3-9567-001a4a2221fb',), 'description': (u'Limited 
admins who can edit other users',)}
   path = ('result', 1)

I think you need the wrap the dictionary discribing the editor's group 
entry with the add_sid wrapper, and its objectclasses using the add_oc 
wrapper.

[tbabej at vm-139 freeipa]$ git diff
diff --git a/ipatests/test_xmlrpc/test_group_plugin.py 
b/ipatests/test_xmlrpc/test_group_plugin.py
index d380fe5..14c70cd 100644
--- a/ipatests/test_xmlrpc/test_group_plugin.py
+++ b/ipatests/test_xmlrpc/test_group_plugin.py
@@ -447,14 +447,15 @@ class test_group(Declarative):
                              objectclasses.posixgroup, 
u'ipantgroupattrs')),
                          'ipauniqueid': [fuzzy_uuid],
                      }),
-                    {
+                    add_sid({
                          'dn': get_group_dn('editors'),
                          'gidnumber': [fuzzy_digits],
                          'cn': [u'editors'],
                          'description': [u'Limited admins who can edit 
other users'],
-                        'objectclass': 
fuzzy_set_ci(objectclasses.posixgroup),
+                        'objectclass': fuzzy_set_ci(add_oc(
+                            objectclasses.posixgroup, u'ipantgroupattrs')),
                          'ipauniqueid': [fuzzy_uuid],
-                    },
+                    }),
                      dict(
                          dn=get_group_dn(group1),
                          cn=[group1],


These changes were sufficient for me to have the unit test suite run 
without errors.

-- 
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130809/87e4f0ad/attachment.htm>