[Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

[Jan Cholasta]

On 19.8.2013 14:02, Petr Viktorin wrote:
> Thanks!
> I've read the patches and have some initial comments; I'll get to
> functional testing (and writing related CA-less tests) right away.
>
> The patches need a small rebase (attached since I did it anyway).
>
> Patch 152: OK (I saw some issues but they're fixed later on)
> Patch 153: You can use log_file_name = '/var/log/ipa/default.log' on the
> ServerCertInstall class to keep the default log file.

What is the benefit in doing this? All ipa-server-certinstall did when 
using this file was complain about /var/log/ipa being non-existent.

> Patch 154: OK
> Patch 155: All this is removed by patch 157, please squash them together.
> Patch 156: OK
> Patch 157: Please add the delete_cert method to the NSSDatabase class,
> and have CertDB call it (see e.g. run_certutil, find_server_certs,
> import_pkcs12). The CertDB is only meant for IPA-specific functionality.
> Patch 158: OK
>

Honza

-- 
Jan Cholasta