[Freeipa-devel] [PATCH] 443 Web UI integration tests: CA-less

[Petr Vobornik]

On 08/20/2013 08:25 PM, Ana Krivokapic wrote:
> On 08/15/2013 04:03 PM, Petr Vobornik wrote:
>> +        if is_visible:
>> +            is_enabled = 'disabled' not in link.get_attribute("class").split(' ')
>
> Nitpick: it would be better to use .split() without arguments here. Here's an
> example that illustrates the difference in behavior between .split() and split('
> ') (e.g. if there are multiple spaces between class names):
>
>>>> 'class1  class2 class3     class4'.split()
> ['class1', 'class2', 'class3', 'class4']
>>>> 'class1  class2 class3     class4'.split(' ')
> ['class1', '', 'class2', 'class3', '', '', '', '', 'class4']
>
> ACK with this change.
>

Fixed all occurrences (4 in total).

Pushed to master and ipa-3-3.
-- 
Petr Vobornik