[Freeipa-devel] [PATCH] 0257 Add initial CA-less installation tests

[Petr Viktorin]

On 08/28/2013 08:10 PM, Jan Cholasta wrote:
> On 28.8.2013 19:39, Petr Viktorin wrote:
>> On 08/28/2013 06:24 PM, Jan Cholasta wrote:
>>> On 28.8.2013 17:15, Petr Viktorin wrote:
>>>> On 08/28/2013 03:23 PM, Jan Cholasta wrote:
>>>>> Thanks.
>>>>>
>>>>> The service-disable and host-disable tests fail with AlreadyInactive,
>>>>> because the certificate is removed with service-mod and host-mod in
>>>>> earlier tests. I think the service and host command tests should look
>>>>> like this:
>>>>>
>>>>> 1. Verify that {service,host}-del does not attempt to revoke
>>>>> {host,service}'s certificate
>>>>>      {service,host}-add
>>>>>      {service,host}-del
>>>>>
>>>>> 2. Verify that {service,host}-mod does not attempt to revoke
>>>>> {host,service}'s certificate
>>>>>      {service,host}-add
>>>>>      {service,host}-mod
>>>>>      {service,host}-del
>>>>>
>>>>> 3. Verify that {service,host}-disable does not attempt to revoke
>>>>> {host,service}'s certificate
>>>>>      {service,host}-add
>>>>>      {service,host}-disable
>>>>>      {service,host}-del
>>>>
>>>> Fixed. I've used context managers so the -del isn't skipped when
>>>> there's
>>>> an error.
>>>>
>>>>> There are a few wrong docstrings:
>>>>>
>>>>> +    def test_service_mod_doesnt_revoke(self):
>>>>> +        "Verify that service-mod does not attempt to revoke host's
>>>>> certificate"
>>>>>
>>>>> +    def test_service_del_doesnt_revoke(self):
>>>>> +        "Verify that service-del does not attempt to revoke host's
>>>>> certificate"
>>>>>
>>>>> +    def test_ds_san(self):
>>>>> +        "Install new HTTP certificate with SAN"
>>>>>
>>>>
>>>> Fixed.
>>>
>>> The TestIPACommands.service context manager does not call service-del.
>>
>> That's not necessary, deleting the host deletes all its services.
>
> Ah, I missed the "with self.host()" part. How silly of me.
>
>>
>>> TestCertInstall.test_ds_san docstring still says "HTTP" instead of "DS".
>>
>> Fixed
>>
>
> ACK!
>

Thanks again! Pushed to
master: 9b200c7c728604018bc56638a3d5e86c29d69099
ipa-3-3: c706859df2ae6a000d33874e4bb6bf79e9e9da52


-- 
Petr³