[Freeipa-devel] [PATCHES] 94-96 Remove Entry and Entity classes

Jan Cholasta jcholast at redhat.com
Mon Feb 4 08:52:56 UTC 2013


On 1.2.2013 16:34, Rob Crittenden wrote:
> Jan Cholasta wrote:
>> On 22.1.2013 15:32, Jan Cholasta wrote:
>>> Hi,
>>>
>>> these patches remove the Entry and Entity classes and move instantiation
>>> of LDAPEntry objects to LDAPConnection.make_entry factory method.
>>>
>>> Apply on top of Petr Viktorin's LDAP code refactoring (part 1 & 2)
>>> patches.
>>>
>>> Honza
>>>
>>
>> Slightly changed patch 95 and rebased all the patches on top of current
>> master and LDAP code refactoring part 1 & 2.
>>
>> Honza
>
> I'm curious why you chose to use __slots__ in the LDAPEntry() class. I'm
> not too familiar with this directive but I always thought it was memory
> management thing, or are you trying to purposely limit the capabilities
> of the class (to prevent us rogue programmers from doing bad things)?
>
> rob
>

It's the first one, I tend to use __slots__ in single-purpose classes 
like LDAPEntry just to save some space.

Honza

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list