[Freeipa-devel] [PATCHES] 0177-0179 Add missing dict methods to CIDict
Petr Viktorin
pviktori at redhat.com
Tue Feb 5 17:02:55 UTC 2013
CIDict, our case-insensitive dictionary, inherits from dict but did not
reimplement the full dict interface. Calling the missing methods
silently invoked case-sensitive behavior. Our code seems to avoid that,
but it's a bit of a minefield for new development.
Patch 119 adds the missing dict methods (except
view{items,keys,values}(), which now raise errors), and adds tests.
Patches 117-118 modernize the testsuite a bit (these have been sitting
in my queue for a while, I think now is a good time to submit them):
The first one moves some old tests from the main code tree to tests/.
(The adtrust_install test wasn't run before, this move makes nose notice
it).
The second converts CIDict's unittest-based suite to nose.
--
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0177-Move-tests-to-test-directories.patch
Type: text/x-patch
Size: 4649 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130205/368cddf7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0178-Convert-test_ipautil-from-unittest-to-nose.patch
Type: text/x-patch
Size: 17739 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130205/368cddf7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0179-Add-missing-dict-methods-to-CIDict.patch
Type: text/x-patch
Size: 6200 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130205/368cddf7/attachment-0002.bin>
More information about the Freeipa-devel
mailing list