[Freeipa-devel] [PATCH] 259 Combobox keyboard support

[Endi Sukma Dewata]

Looks good. The patch already provides improvements, so feel free to push.

>    * when CB is non-editable, user can start typing, first character
> will open list, second will be entered into search input. Note: I
> wanted to copy the first char to the search box as well, but I did not
> figure out reliable method for converting keycode to char for non ASCII
> keyboard layouts

Could we use keypress() for this instead of keydown()? See http://api.jquery.com/keypress/. The keypress() should return the actual character, whereas the keydown() would return the code of the keyboard key so it wouldn't be able to distinguish between 'a' and 'A', which is not what we want.

Another minor thing, if the search box is in focus, you can use the Up/Down arrow to go to the list. However, from the list you cannot use the Up/Down arrow to go back to the search box, you'd have to use the Tab key. It's not really a problem, but it's not that consistent.

--
Endi S. Dewata