[Freeipa-devel] [PATCHES] 0117-0118 Port ipa-replica-prepare to the admintool framework

[Petr Viktorin]

Hello,

The first patch implements logging-related changes to the admintool 
framework and ipa-ldap-updater (the only thing ported to it so far).
The design document is at http://freeipa.org/page/V3/Logging_and_output

John, I decided to go ahead and put an explicit "logger" attribute on 
the tool class rather than adding debug, info, warn. etc methods 
dynamically using log_mgr.get_logger. I believe it's the cleanest solution.
We had a discussion about this in this thread: 
https://www.redhat.com/archives/freeipa-devel/2012-July/msg00223.html; I 
didn't get a reaction to my conclusion so I'm letting you know in case 
you have more to say.



The second patch ports ipa-replica-prepare to the framework. (I chose 
ipa-replica-prepare because there was a bug filed against its error 
handling, something the framework should take care of.)
As far as Git can tell, it's a complete rewrite, so it might be hard to 
do a review. I have several smaller patches that make it easier to see 
what gets moved where. Please say I'm wrong, but as I understand, broken 
commits aren't allowed in the FreeIPA repo so I can only present the 
squashed patch for review.
To get the smaller commits, do `git fetch 
git://github.com/encukou/freeipa.git 
replica-prepare:pviktori-replica-prepare`.

Part of: https://fedorahosted.org/freeipa/ticket/2652
Fixes: https://fedorahosted.org/freeipa/ticket/3285

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0117-Better-logging-for-AdminTool-and-ipa-ldap-updater.patch
Type: text/x-patch
Size: 15733 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130103/738b4adb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0118-Port-ipa-replica-prepare-to-the-admintool-framework.patch
Type: text/x-patch
Size: 45488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130103/738b4adb/attachment-0001.bin>