[Freeipa-devel] [PATCH] 240-252 AMD modules and Web UI build

[Endi Sukma Dewata]

On 1/8/2013 11:46 PM, Petr Vobornik wrote:
> This patchset does following things:
>   * integrates Dojo library into FreeIPA Web UI
>   * encapsulates UI parts by AMD definition so they can be used in build
> process and by AMD loader
>   * introduces Dojo builder for building Web UI and UglifyJS for
> minimizing JS
>   * contains help and build scripts for developers and a make process
>
> Overall it makes final application smaller, faster loadable and it's a
> foundation for additional refactoring.
>
> More information in design page: http://www.freeipa.org/page/V3/WebUI_build
>
> https://fedorahosted.org/freeipa/ticket/112
>
> These patches introduce one regression: extension.js file isn't used. I
> want to fix it in #3235 ([RFE] Make WebUI extensions functional just by
> adding files). Which I will implement after I finish #3236 ([RFE] more
> extensible navigation) on which I'm working now.

Nice work! They seem to be working fine so it's ACKed.
I have some questions though:

1. Patch #241 includes another patch 
(001-dojo-build-pvoborni-01-Make-dojo-builder-buildable-by-itself.patch). Is 
there an instruction how and where to use the patch?

2. Is there a way to disable uglify in case we need to debug with Firebug?

3. Is it possible to set breakpoints in AMD modules in Firebug, for 
example line 44 in widget.js?

4. Calling change-profile.sh allsource modifies the install/ui/js/dojo. 
Should they be included in .gitignore? Or is there a way to select the 
profile without modifying any files included in git (e.g. using 
parameter)? The concern is that the changes could accidentally get 
checked in and affect the official build.

-- 
Endi S. Dewata