[Freeipa-devel] [PATCHES] 127-136 LDAP code refactoring (Part 2)

[Petr Viktorin]

On 01/21/2013 06:38 PM, Petr Viktorin wrote:
> On 01/17/2013 06:27 PM, Petr Viktorin wrote:
>> Hello,
>> This is the first batch of changes aimed to consolidate our LDAP code.
>> Each should be a self-contained change that doesn't break anything.
>>
>> These patches do some general cleanup (some of the changes might seem
>> trivial but help a lot when grepping through the code); merge the common
>> parts LDAPEntry, Entry and Entity classes; and move stuff that depends
>> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>>
>> I'm posting them early so you can see where I'm going, and so you can
>> find out if your work will conflict with mine.
>
> Here is a second batch of patches. I'm keeping them small so they're
> easier to digest (and rebase, should that be necessary). If you prefer
> big patches, just squash them.
> Obviously, they apply on top of the previous batch.
>
> Here we introduce a base class, LDAPConnection, from which IPAdmin and
> ldap2 inherit. This makes IPAdmin support both interfaces, its own old
> one and the new common one.
> Both IPAdmin and ldap2 work with the common Entry class, LDAPEntry,
> which also has both the old and new interface for the moment.
> To use a hyperbole, the rest of the work is simply rewriting the
> codebase to use the new interfaces.
> And testing.
>

I moved the wrong method in patch 0133, which broke the memberof logic.
Attaching a fixed version of patches 0132-0135 (so many because the 
change introduced minor merge conflicts).

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0132-02-Move-filter-making-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 13423 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130122/acfae7ca/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0133-02-Move-entry-finding-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 28182 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130122/acfae7ca/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0134-02-Remove-unused-proxydn-functionality-from-IPAdmin.patch
Type: text/x-patch
Size: 5781 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130122/acfae7ca/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0135-02-Move-entry-add-update-remove-rename-to-LDAPConnectio.patch
Type: text/x-patch
Size: 12320 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130122/acfae7ca/attachment-0003.bin>