[Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

Petr Viktorin pviktori at redhat.com
Fri Jan 25 13:54:25 UTC 2013


On 01/24/2013 03:06 PM, Petr Viktorin wrote:
> On 01/24/2013 10:43 AM, Petr Viktorin wrote:
>> On 01/22/2013 04:04 PM, Petr Viktorin wrote:
>>> On 01/21/2013 06:38 PM, Petr Viktorin wrote:
>>>> On 01/17/2013 06:27 PM, Petr Viktorin wrote:
>>>>> Hello,
>>>>> This is the first batch of changes aimed to consolidate our LDAP code.
>>>>> Each should be a self-contained change that doesn't break anything.
>>>>>
>>>>> These patches do some general cleanup (some of the changes might seem
>>>>> trivial but help a lot when grepping through the code); merge the
>>>>> common
>>>>> parts LDAPEntry, Entry and Entity classes; and move stuff that depends
>>>>> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>>>>>
>>>>> I'm posting them early so you can see where I'm going, and so you can
>>>>> find out if your work will conflict with mine.
>>
>
> Here is a third set of patches. These apply on top of jcholast's patches
> 94-96.
>

I found mistakes in two of the patches, attaching fixed versions.



Since this patchset is becoming unwieldy, I've put it in a public repo 
that I'll keep updated. The following command will fetch it into your 
"pviktori-ldap-refactor" branch:

     git fetch git://github.com/encukou/freeipa 
ldap-refactor:pviktori-ldap-refactor


-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0129-02-Make-IPAdmin-not-inherit-from-IPASimpleLDAPObject.patch
Type: text/x-patch
Size: 7287 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130125/59610996/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0137-02-Replace-setValue-by-keyword-arguments-when-creating-.patch
Type: text/x-patch
Size: 25695 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130125/59610996/attachment-0001.bin>


More information about the Freeipa-devel mailing list