[Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

[Jan Cholasta]

On 28.1.2013 09:34, Jan Cholasta wrote:
> On 25.1.2013 14:54, Petr Viktorin wrote:
>> On 01/24/2013 03:06 PM, Petr Viktorin wrote:
>>> On 01/24/2013 10:43 AM, Petr Viktorin wrote:
>>>> On 01/22/2013 04:04 PM, Petr Viktorin wrote:
>>>>> On 01/21/2013 06:38 PM, Petr Viktorin wrote:
>>>>>> On 01/17/2013 06:27 PM, Petr Viktorin wrote:
>>>>>>> Hello,
>>>>>>> This is the first batch of changes aimed to consolidate our LDAP
>>>>>>> code.
>>>>>>> Each should be a self-contained change that doesn't break anything.
>>>>>>>
>>>>>>> These patches do some general cleanup (some of the changes might
>>>>>>> seem
>>>>>>> trivial but help a lot when grepping through the code); merge the
>>>>>>> common
>>>>>>> parts LDAPEntry, Entry and Entity classes; and move stuff that
>>>>>>> depends
>>>>>>> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>>>>>>>
>>>>>>> I'm posting them early so you can see where I'm going, and so you
>>>>>>> can
>>>>>>> find out if your work will conflict with mine.
>>>>
>>>
>>> Here is a third set of patches. These apply on top of jcholast's patches
>>> 94-96.
>>>
>>
>> I found mistakes in two of the patches, attaching fixed versions.
>>
>>
>>
>> Since this patchset is becoming unwieldy, I've put it in a public repo
>> that I'll keep updated. The following command will fetch it into your
>> "pviktori-ldap-refactor" branch:
>>
>>      git fetch git://github.com/encukou/freeipa
>> ldap-refactor:pviktori-ldap-refactor
>>
>>
>
> I don't think patch 139 is necessary, I fixed this problem in patch 95
> by not including 'dn' as attribute in _entry_to_entity.
>

A patch from this patchset (part 3) causes some of the dns plugin tests 
to fail (idnsallowdynupdate is missing in dnszone_add output).

Honza

-- 
Jan Cholasta