[Freeipa-devel] [PATCHES] 146-164 LDAP code refactoring (Part 4)

[Petr Viktorin]

On 01/29/2013 04:39 PM, Petr Viktorin wrote:
> On 01/28/2013 04:09 PM, Petr Viktorin wrote:
>> On 01/28/2013 09:34 AM, Jan Cholasta wrote:
>>> On 25.1.2013 14:54, Petr Viktorin wrote:
>>>> On 01/24/2013 03:06 PM, Petr Viktorin wrote:
>>>>> On 01/24/2013 10:43 AM, Petr Viktorin wrote:
>>>>>> On 01/22/2013 04:04 PM, Petr Viktorin wrote:
>>>>>>> On 01/21/2013 06:38 PM, Petr Viktorin wrote:
>>>>>>>> On 01/17/2013 06:27 PM, Petr Viktorin wrote:
>>>>>>>>> Hello,
>>>>>>>>> This is the first batch of changes aimed to consolidate our LDAP
>>>>>>>>> code.
>>>>>>>>> Each should be a self-contained change that doesn't break
>>>>>>>>> anything.
>>>>>>>>>
>>>>>>>>> These patches do some general cleanup (some of the changes might
>>>>>>>>> seem
>>>>>>>>> trivial but help a lot when grepping through the code); merge the
>>>>>>>>> common
>>>>>>>>> parts LDAPEntry, Entry and Entity classes; and move stuff that
>>>>>>>>> depends
>>>>>>>>> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>>>>>>>>>
>>>>>>>>> I'm posting them early so you can see where I'm going, and so you
>>>>>>>>> can
>>>>>>>>> find out if your work will conflict with mine.
>>>>>>
>>>>>
>>>>> Here is a third set of patches. These apply on top of jcholast's
>>>>> patches
>>>>> 94-96.
>>>>>
>>>>
>>>> I found mistakes in two of the patches, attaching fixed versions.
>>>>
>>>>
>>>>
>>>> Since this patchset is becoming unwieldy, I've put it in a public repo
>>>> that I'll keep updated. The following command will fetch it into your
>>>> "pviktori-ldap-refactor" branch:
>>>>
>>>>      git fetch git://github.com/encukou/freeipa
>>>> ldap-refactor:pviktori-ldap-refactor
>>>>
>>>>
>>>
>>> I don't think patch 139 is necessary, I fixed this problem in patch 95
>>> by not including 'dn' as attribute in _entry_to_entity.
>>>
>>
>> You're right. I'm retiring patch 139.
>> We'll need to use entry.dn everywhere, and add an assert so that
>> entry['dn'] is never set.
>>
>>
>> Here is a fourth set of patches.
>>
>
> Honza noticed test failures caused by patch 143. Patch 123 grew a
> conflict with master. Fixes attached.
>

Today, patch 144 had a merge conflict.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0144-02-Remove-unused-imports-from-ipaserver-install.patch
Type: text/x-patch
Size: 11144 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130130/1a0e3884/attachment.bin>