[Freeipa-devel] [PATCH] 0041 Fix bug in adtrustinstance

[Rob Crittenden]

Alexander Bokovoy wrote:
> On Tue, 25 Jun 2013, Ana Krivokapic wrote:
>> Hello,
>>
>> Attached patch fixes https://fedorahosted.org/freeipa/ticket/3746.
>>
>> --
>> Regards,
>>
>> Ana Krivokapic
>> Associate Software Engineer
>> FreeIPA team
>> Red Hat Inc.
>>
>
>> From 548f1626dbf9edf45bfcab358b28e510d1ec5757 Mon Sep 17 00:00:00 2001
>> From: Ana Krivokapic <akrivoka at redhat.com>
>> Date: Tue, 25 Jun 2013 15:52:29 +0200
>> Subject: [PATCH] Fix bug in adtrustinstance
>>
>> Incorrect tuple unpacking in adtrustinstance was causing
>> ipa-adtrust-install
>> to fail when IPA was installed with no DNS.
>>
>> https://fedorahosted.org/freeipa/ticket/3746
>> ---
>> ipaserver/install/adtrustinstance.py | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ipaserver/install/adtrustinstance.py
>> b/ipaserver/install/adtrustinstance.py
>> index
>> d2929801b431625764e5b949349ab63d2caaf696..4eb20d9517906df0b1952fe5033a050f3b55a797
>> 100644
>> --- a/ipaserver/install/adtrustinstance.py
>> +++ b/ipaserver/install/adtrustinstance.py
>> @@ -535,9 +535,9 @@ def __add_dns_service_records(self):
>>             self.print_msg(err_msg)
>>             self.print_msg("Add the following service records to your
>> DNS " \
>>                            "server for DNS zone %s: " % zone)
>> -            for (srv, rdata) in ipa_srv_rec:
>> +            for srv in ipa_srv_rec:
>>                 for suff in win_srv_suffix:
>> -                    self.print_msg(" - %s%s"  % (srv, suff))
>> +                    self.print_msg(" - %s%s"  % (srv[0], suff))
>>             return
>>
>>         for (srv, rdata, port) in ipa_srv_rec:
> ACK.
>
>

pushed to master and ipa-3-2