[Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

[Lukas Slebodnik]

On (10/07/13 11:14), Jakub Hrozek wrote:
>On Wed, Jul 10, 2013 at 10:59:10AM +0200, Lukas Slebodnik wrote:
>> On (10/07/13 10:48), Jakub Hrozek wrote:
>> >On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote:
>> >> On (04/07/13 15:23), Petr Spacek wrote:
>> >> >Hello,
>> >> >
>> >> >several warnings from autotools popped up after upgrade to Fedora 19.
>> >> >Attached patches should make autotools configuration more modern.
>> >> >
>> >> >-- 
>> >> >Petr^2 Spacek
>> >> 
>> >> >From 07caec808e394bfcbd898905e917731cb3778e68 Mon Sep 17 00:00:00 2001
>> >> >From: Petr Spacek <pspacek at redhat.com>
>> >> >Date: Thu, 4 Jul 2013 14:04:57 +0200
>> >> >Subject: [PATCH] Add missing ar check to configure.ac.
>> >> >
>> >> >Signed-off-by: Petr Spacek <pspacek at redhat.com>
>> >> >---
>> >> > configure.ac | 1 +
>> >> > 1 file changed, 1 insertion(+)
>> >> >
>> >> >diff --git a/configure.ac b/configure.ac
>> >> >index 222e520e0aa61bca58cff81bea672fcab04355b3..b6d66de1b862a6860226a5f9ae4a3f33842e6100 100644
>> >> >--- a/configure.ac
>> >> >+++ b/configure.ac
>> >> >@@ -10,6 +10,7 @@ AC_CONFIG_HEADERS([config.h])
>> >> > AC_DISABLE_STATIC
>> >> > 
>> >> > # Checks for programs.
>> >> >+AM_PROG_AR
>> >> > AC_PROG_CC
>> >> > AC_PROG_LIBTOOL
>> >> > 
>> >> >-- 
>> >> >1.8.3.1
>> >> >
>> >> 
>> >> This solution is not very portable. Automake <= 1.11 does not contain this
>> >> macro.
>> >> 
>> >> configure.ac:14: warning: macro `AM_PROG_AR' not found in library
>> >> configure.ac:14: error: possibly undefined macro: AM_PROG_AR
>> >>       If this token and others are legitimate, please use m4_pattern_allow.
>> >>       See the Autoconf documentation.
>> >> autoreconf: /usr/bin/autoconf failed with exit status: 1
>> >> 
>> >> Better solution will be:
>> >> m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>> >> 
>> >> You can find more information about this in mail thread
>> >> http://lists.gnu.org/archive/html/automake/2012-05/msg00014.html
>> You probably did not read this page ^^^^^
>
>No I didn't :)
>
>But what the guy says there isn't true, m4_pattern_allow works just fine
>even with the old autoconf version in RHEL5.
>
>> 
>> >>Even better is:
>> >m4_pattern_allow([AM_PROG_AR])
>> >AM_PROG_AR
>> 
>> m4_pattern_allow should be used for another things.
>> http://www.gnu.org/software/autoconf/manual/autoconf.html#Forbidden-Patterns
>
>Dunno, I think it'quite pretty established pattern. Is there something wrong
>with it?

Macro "m4_pattern_allow" only suppresses autotool error "possibly undefined macro",
but there still will be a warning "macro `AM_PROG_AR' not found in library"
Autreconf will not fail with older versions of automake (<=1.11), but macro
AM_PROG_AR will not be expanded and you can find this "unexpanded text" in
configure script. It is harmless.
Everything will work well, but we don't like warnings.

LS