[Freeipa-devel] [PATCHES] 149-151 Ask for PKCS#12 password interactively

Jan Cholasta jcholast at redhat.com
Mon Jul 15 08:57:37 UTC 2013


On 12.7.2013 10:19, Tomas Babej wrote:
> Just a nitpick:
>
> + # If any of the PKCS#12 options are selected, all are required.
>
> + pkcs12_req = (options.dirsrv_pkcs12, options.http_pkcs12)
>
> + pkcs12_opt = (options.pkinit_pkcs12,)
>
> + if any(pkcs12_req + pkcs12_opt) and not all(pkcs12_req):
>
> parser.error("All PKCS#12 options are required if any are used.")
>
> This error message is somewhat misleading, since --pkinit-pkcs12 options
> is not required.

Fixed.

Updated patches attached.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-149.2-Ask-for-PKCS-12-password-interactively-in-ipa-server.patch
Type: text/x-patch
Size: 5402 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130715/169594f9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-150.2-Ask-for-PKCS-12-password-interactively-in-ipa-replic.patch
Type: text/x-patch
Size: 4093 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130715/169594f9/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-151.2-Print-newline-after-receiving-EOF-in-installutils.re.patch
Type: text/x-patch
Size: 8163 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130715/169594f9/attachment-0002.bin>


More information about the Freeipa-devel mailing list