[Freeipa-devel] [PATCH] 0047 Honor 'enabled' option for widgets

[Petr Vobornik]

On 07/17/2013 09:18 PM, Ana Krivokapic wrote:
> Hello,
>
> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3793.
>

Hello,

1) IMO  we should not create attribute which is just a negation of another.

2) We should add set_enabled method to base widget. Existing set_enabled 
methods should use it and maintain widget output consistent with the 
attribute (ie. one should not directly set the attr and should use 
set_enabled instead). The method should be also callable when content is 
not yet created.  get_enabled methods might become unnecessary - one can 
get the state form 'enabled' attribute.

-- 
Petr Vobornik