[Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

[Petr Vobornik]

On 07/19/2013 04:01 PM, Petr Vobornik wrote:
> On 07/19/2013 03:49 PM, Jan Cholasta wrote:
>> On 19.7.2013 13:10, Petr Vobornik wrote:
>>> On 07/18/2013 05:29 PM, Jan Cholasta wrote:
>>>> On 18.7.2013 17:26, Martin Kosek wrote:
>>>>> On 07/18/2013 05:22 PM, Jan Cholasta wrote:
>>>>>> On 18.7.2013 17:07, Martin Kosek wrote:
>>>>>>> On 07/18/2013 04:53 PM, Jan Cholasta wrote:
>>>>>>>> Added patch which adds new hidden option no_members to suppress
>>>>>>>> membership
>>>>>>>> processing for commands of all objects that have member attributes.
>>>>>>>> This can be
>>>>>>>> used by the WebUI to prevent member lookups where they are not
>>>>>>>> necessary (as we
>>>>>>>> discussed off-line with Martin and Petr).
>>>>>>>>
>>>>>>>> Honza

snip

>>>>>>>
>>>>>>> 3) It would be nice to state that this option is mutually exclusive
>>>>>>> with --all,
>>>>>>> but given it is internal anyway and there is no central place to
>>>>>>> define it, we
>>>>>>> do not need to do that.
>>>>>>
>>>>>> The options are not really mutually exclusive at this point, they
>>>>>> can be
>>>>>> specified together, --all takes precedence.
>>>>>
>>>>> Well, they can be specified together, but the option is then NOOP
>>>>> which could
>>>>> confuse users which may have different expectations. Being explicit
>>>>> helps.
>>>>
>>>> I agree.
>>>>
>>>>> But
>>>>> as I said, in this case this is not a requirement.
>>>>
>>>> I agree as well :-)
>>>>
>>>> Honza
>>>>
>>>
>>> Functional ACK for Honza's patch (didn't break Web UI test suite)
>>>
>>> Attaching Web UI patch.
>>>
>>> It:
>>> 1) Removed --all from _find and _show commands used by search pages. All
>>> displayed attributes should be already included in default attributes.
>>>
>>> 2) Removed search_all_attributes - Not needed since introduction of
>>> paging.
>>>
>>> 3) Added --no-members options to search _show commmands.
>>
>> Hmm, is the has_members function used to distinguish between objects
>> with members and without members? If so, would it be helpful to add the
>> no_members option to all commands (just like "all" and "raw"), so that
>> you don't have to do this check?
>>
>> Honza
>>
>
> Yes, that's its purpose. IMO it doesn't matter now, the function is
> implemented. The only benefits would be small, not noticeable,
> performance gain and tolerance to incorrect use of --no-members. Doesn't
> look like a reason for polluting all commands with it.

Here are backports of jcholast-160 and pvoborni-435 to ipa-3-0.
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-160-ipa-3-0-Add-new-hidden-command-option-to-suppress-processing.patch
Type: text/x-patch
Size: 113901 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130719/0e94ca03/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0435-ipa-3-0-Web-UI-search-optimization.patch
Type: text/x-patch
Size: 5898 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130719/0e94ca03/attachment-0001.bin>