[Freeipa-devel] [PATCH] 429 Make ssh_widget not-editable if attr is readonly

Ana Krivokapic akrivoka at redhat.com
Mon Jul 29 12:21:36 UTC 2013


On 07/29/2013 11:45 AM, Petr Vobornik wrote:
>              dialog.textarea = $('<textarea/>', {
>                  'class': 'certificate',
> -                readonly: that.read_only,
> +                readonly: !writable,
>                  disabled: !that.enabled
>              }).appendTo(dialog.container);

I suggest setting the 'disabled' attribute on the text area in case it's not
writable:

    disabled: !that.enabled || !writable

That way, when the user opens the dialog, the textarea is greyed out and it is
immediately clear that it is not editable.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.




More information about the Freeipa-devel mailing list