[Freeipa-devel] [PATCH] 0051 Handle --subject option in ipa-server-install

[Petr Viktorin]

On 07/30/2013 10:27 AM, Ana Krivokapic wrote:
> Hello,
>
> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3783.
>

Thanks for the patch, I have a concern below:

> freeipa-akrivoka-0051-Handle-subject-option-in-ipa-server-install.patch
> diff --git a/install/tools/ipa-upgradeconfig b/install/tools/ipa-upgradeconfig
> index de17c5b23d79f31e8571a3400d44397630cadada..a2625e6198bcff0811c482e479c8af10716dcea1 100644
> --- a/install/tools/ipa-upgradeconfig
> +++ b/install/tools/ipa-upgradeconfig
> @@ -894,6 +895,7 @@ def main():
>       configured_constants = dogtag.configured_constants()
>       sub_dict = dict(
>           REALM=api.env.realm,
> +        SUBJECT_BASE=str(DN(('O', api.env.realm))),

When certmap.conf.template's version changes again, this will rewrite 
the subject to the default. Don't we want to use the subject base also here?



-- 
Petr³