[Freeipa-devel] [PATCHES 0061-0063] Extend ID range types <rebased>

Alexander Bokovoy abokovoy at redhat.com
Fri Jun 7 13:41:10 UTC 2013


Hi,

in patch 0061:

On Fri, 07 Jun 2013, Tomas Babej wrote:
>+    range_types = {
>+        u'ipa-local': unicode(_(u'local domain range')),
>+        u'ipa-ad-winsync': unicode(_('Active Directory winsync range')),
>+        u'ipa-ad-trust': unicode(_('Active Directory domain range')),
>+        u'ipa-ad-trust-posix': unicode(_('Active Directory trust range with '
>+                                        'POSIX attributes')),
>+        u'ipa-ipa-trust': unicode(_('IPA trust range')),
>+                  }
Why there is _(u'local domain range') and then others without Unicode
strings? Either way is fine but there should be consistency.

The rest of this patch would be much shorter if there wouldn't
additional whitespace. Could you please git rid of that?

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list